Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63183 )
Change subject: util/amdfwtool: use table-relative addressing in ISH case ......................................................................
util/amdfwtool: use table-relative addressing in ISH case
When the image slot header (ISH) is used, the addresses in the PSP and BIOS directory tables need to be relative to the beginning of the table.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ia61f7c8313d5a1af95c68b9177a53a2f5443552a --- M util/amdfwtool/amdfwtool.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/63183/1
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 0cfe307..9e7f920 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -1798,7 +1798,9 @@ fprintf(stderr, "WARNING: No SOC name specified.\n"); }
- if (amd_romsig->efs_gen.gen == EFS_SECOND_GEN) + if (cb_config.need_ish) + ctx.address_mode = ADDRESS_MODE_2_REL_TAB; + else if (amd_romsig->efs_gen.gen == EFS_SECOND_GEN) ctx.address_mode = ADDRESS_MODE_1_REL_BIOS; else ctx.address_mode = ADDRESS_MODE_0_PHY;