[XS] Change in coreboot[main]: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker - coreboot-gerrit

25 Nov 2023


      Attention is currently required from: Arthur Heymans, Paul Menzel, Srinivas Hegde.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79218/comment/a2e6bfb1_f1638c2d :
PS4, Line 10: ramstage. This is superflous as these are only meant to be compiler flags and should not be passed to the linker.
Please wrap at 72 characters max.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878
Gerrit-Change-Number: 79218
Gerrit-PatchSet: 4
Gerrit-Owner: Srinivas Hegde srinivashegde@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Patrick Georgi patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Srinivas Hegde srinivashegde@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 24 Nov 2023 23:24:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment