Nico Huber has posted comments on this change. ( https://review.coreboot.org/20913 )
Change subject: [WIP]mb/lenovo/x200: Add ACPI methods to set battery thresholds ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/20913/1/src/mainboard/lenovo/x200/acpi/bat_t... File src/mainboard/lenovo/x200/acpi/bat_thresh.asl:
PS1: I think we agreed to keep the tree consistent in the old syntax for the moment.
https://review.coreboot.org/#/c/20913/1/src/mainboard/lenovo/x200/acpi/bat_t... PS1, Line 32: 1 Why not place them below BAT0/BAT1? instead of numbering the methods? (not to mention that it's weird to have a different numbering, 1 based here, 0 based there)