[XS] Change in coreboot[main]: mb/google/puff: Use auto fan control - coreboot-gerrit

12 Jul 2024


      Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83410?usp=email )
Change subject: mb/google/puff: Use auto fan control
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/puff/Kconfig:
https://review.coreboot.org/c/coreboot/+/83410/comment/c85f919e_8d0ae25f?usp... :
PS1, Line 17: 	select EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL
Since this should be applied for non-ChromeOS builds, shouldn't this be conditional on !CHROMEOS?
```suggestion
    select EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL if !CHROMEOS
```
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I478cdb95757671d4ecd9c2d45af2aa1d53b4b833
Gerrit-Change-Number: 83410
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No