Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Angel Pons, Patrick Rudolph, EricR Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62723 )
Change subject: soc/intel/common: Configure TCSS access through IOE P2SB ......................................................................
Patch Set 6:
(11 comments)
File src/soc/intel/alderlake/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/882315de_6af7a93d PS6, Line 854: config->common_soc_config.tcss_ops.valid_tbt_auth = tcss_valid_tbt_auth; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/ce50fa01_5f3f593b PS6, Line 854: config->common_soc_config.tcss_ops.valid_tbt_auth = tcss_valid_tbt_auth; please, no spaces at the start of a line
File src/soc/intel/common/block/include/intelblocks/tcss.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/1ef33b05_056b2390 PS6, Line 141: void (*configure_aux_bias_pads)(const struct typec_aux_bias_pads *pads); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/181e3814_b67305ac PS6, Line 141: void (*configure_aux_bias_pads)(const struct typec_aux_bias_pads *pads); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/5f5c9945_3174c14c PS6, Line 142: bool (*valid_tbt_auth)(void); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/5aa4690e_1fa1b2b8 PS6, Line 142: bool (*valid_tbt_auth)(void); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/fcc7de4d_43bc83a3 PS6, Line 155: const struct typec_aux_bias_pads aux_bias_pads[MAX_TYPE_C_PORTS]); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/18d396d1_bd142ca7 PS6, Line 155: const struct typec_aux_bias_pads aux_bias_pads[MAX_TYPE_C_PORTS]); please, no spaces at the start of a line
File src/soc/intel/common/block/usb4/usb4.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/7bab1333_d331f1a0 PS6, Line 32: const struct soc_intel_common_config *config = chip_get_common_soc_structure(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/096e0f55_5849f7c8 PS6, Line 32: const struct soc_intel_common_config *config = chip_get_common_soc_structure(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144291): https://review.coreboot.org/c/coreboot/+/62723/comment/096d5004_af1ceb9e PS6, Line 34: if(!config->tcss_ops.valid_tbt_auth()) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)