Attention is currently required from: Henry Sun, EricR Lai.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51288 )
Change subject: mb/google/octopus/var/fleex: Only check LTE sku on fleex
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/51288/comment/5bc9190e_501b4e7b
PS3, Line 18: return (sku_id >= MIN_LTE_SKU);
Just a nit: since we will return earlier here, the else in next can be ignored.
if (sku_id <= FLEEX_MAX_SKU)
return (sku_id >= MIN_LTE_SKU);
return false;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51288
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f3d5fed4315fc716acad1a07735221d154c377e
Gerrit-Change-Number: 51288
Gerrit-PatchSet: 3
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Mar 2021 12:52:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment