[XS] Change in coreboot[main]: mainboard/google/fatcat: Fix SMBIOS Processor upgrade info
Attention is currently required from: Subrata Banik, Zhixing Ma.
Jérémy Compostella has posted comments on this change by Zhixing Ma. ( https://review.coreboot.org/c/coreboot/+/85960?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mainboard/google/fatcat: Fix SMBIOS Processor upgrade info ......................................................................
Patch Set 7:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85960/comment/8c34eb5a_9f393ada?usp... : PS7, Line 9: The current SMBIOS for fatcat is missing processor upgrade info, information . instead of ,
https://review.coreboot.org/c/coreboot/+/85960/comment/454dc6b6_70b78edd?usp... : PS7, Line 10: This patch adds the missing value by enabling a kconfig flag. which Kconfig flag ?
https://review.coreboot.org/c/coreboot/+/85960/comment/508964f9_f0832323?usp... : PS7, Line 12: https://web.archive.org/web/20221012222420/https://www.dmtf.org/sites/defaul... can't you give the direct link https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.6.0.p... ?
https://review.coreboot.org/c/coreboot/+/85960/comment/3fb2dd8d_02a57d36?usp... : PS7, Line 15: TEST=Boot and verified that SMBIOS processor upgrade value is correct. I would keep the BUG and TEST tags at the end of the commit message.
https://review.coreboot.org/c/coreboot/+/85960/comment/358f24a8_2fbaccde?usp... : PS7, Line 18: Processor Information I would personally prefer a diff representation like ``` Processor Information Socket Designation: CPU0 Type: Central Processor Family: Pentium Pro Manufacturer: GenuineIntel ID: C0 06 0C 00 FF FB EB BF Signature: Type 0, Family 6, Model 204, Stepping 0 Flags: ... Version: Genuine Intel(R) 0000 Voltage: Unknown Max Speed: 3200 MHz Current Speed: 3000 MHz Status: Populated, Enabled - Upgrade: Unknown + Upgrade: Other ```
-
Jérémy Compostella (Code Review)