Attention is currently required from: Aaron Durbin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52030 )
Change subject: mb/google/dedede: add discrete TPM 2.0 configuration
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/52030/comment/f0886974_a18a3f60
PS2, Line 83: PAD_CFG_NF(GPP_B18, NONE, DEEP, NF1),
To avoid preprocessor usage, I would extract GSPI1 pad config into two arrays, and program the corresponding array according to `CONFIG(BOARD_GOOGLE_BASEBOARD_DEDEDE_CR50)`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52030
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2bdb1ca4fd78cc0628256d49678ea042c55f6fba
Gerrit-Change-Number: 52030
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Sun, 04 Apr 2021 12:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment