Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85880?usp=email )
Change subject: tree: Use "true", "false" for *acoustic_noise_mitigation ......................................................................
tree: Use "true", "false" for *acoustic_noise_mitigation
acoustic_noise_mitigation & enable_acoustic_noise_mitigation are boolean, so use true false instead of 0, 1.
Change-Id: Icb1d2743222ff5100527fc6413cc13226a087904 Signed-off-by: Elyes Haouas ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/85880 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/google/brya/variants/anahera/overridetree.cb M src/mainboard/google/brya/variants/anahera4es/overridetree.cb M src/mainboard/google/brya/variants/crota/overridetree.cb M src/mainboard/google/brya/variants/gimble/overridetree.cb M src/mainboard/google/brya/variants/gimble4es/overridetree.cb M src/mainboard/google/brya/variants/joxer/overridetree.cb M src/mainboard/google/brya/variants/kano/overridetree.cb M src/mainboard/google/brya/variants/marasov/overridetree.cb M src/mainboard/google/brya/variants/primus/overridetree.cb M src/mainboard/google/brya/variants/pujjo/overridetree.cb M src/mainboard/google/brya/variants/pujjoga/overridetree.cb M src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb M src/mainboard/google/brya/variants/redrix/overridetree.cb M src/mainboard/google/brya/variants/redrix4es/overridetree.cb M src/mainboard/google/brya/variants/riven/overridetree.cb M src/mainboard/google/brya/variants/rull/overridetree.cb M src/mainboard/google/brya/variants/sundance/overridetree.cb M src/mainboard/google/brya/variants/taeko/overridetree.cb M src/mainboard/google/brya/variants/taeko4es/overridetree.cb M src/mainboard/google/brya/variants/taniks/overridetree.cb M src/mainboard/google/brya/variants/telith/overridetree.cb M src/mainboard/google/brya/variants/xol/overridetree.cb M src/mainboard/google/brya/variants/zydron/overridetree.cb M src/mainboard/google/rex/variants/screebo/overridetree.cb M src/mainboard/prodrive/atlas/devicetree.cb 25 files changed, 25 insertions(+), 25 deletions(-)
Approvals: build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index 4cc2efc..95787ee 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -29,7 +29,7 @@ register "usb2_phy_sus_pg_disable" = "1"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb index 2e14c64..33daa99 100644 --- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb @@ -24,7 +24,7 @@ chip soc/intel/alderlake register "sagv" = "SaGv_Enabled" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb index 1facf07..7b0fd59 100644 --- a/src/mainboard/google/brya/variants/crota/overridetree.cb +++ b/src/mainboard/google/brya/variants/crota/overridetree.cb @@ -48,7 +48,7 @@ }"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb index ce705f7..3148996 100644 --- a/src/mainboard/google/brya/variants/gimble/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb @@ -25,7 +25,7 @@ register "platform_pmax" = "143" register "tcss_aux_ori" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb index a81425b..802e11e 100644 --- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb @@ -25,7 +25,7 @@ register "platform_pmax" = "143" register "tcss_aux_ori" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/joxer/overridetree.cb b/src/mainboard/google/brya/variants/joxer/overridetree.cb index c12d412..c7849d2 100644 --- a/src/mainboard/google/brya/variants/joxer/overridetree.cb +++ b/src/mainboard/google/brya/variants/joxer/overridetree.cb @@ -17,7 +17,7 @@ register "sagv" = "SaGv_Enabled"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index 7620dde..6e3383e 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -36,7 +36,7 @@ register "pmc_gpe0_dw1" = "GPP_D"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb index 57f0c90..add5181 100644 --- a/src/mainboard/google/brya/variants/marasov/overridetree.cb +++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb @@ -29,7 +29,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index c7a1882..893b3cf 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -31,7 +31,7 @@ register "usb2_phy_sus_pg_disable" = "1"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb index 082d3dd..60b35d7 100644 --- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb @@ -55,7 +55,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb index 8877c41..e1ac962 100644 --- a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb @@ -12,7 +12,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb b/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb index a10ae5f..ba70a31 100644 --- a/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb +++ b/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb @@ -12,7 +12,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index 6a35fc6..f26d133 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -42,7 +42,7 @@ register "fivr_spread_spectrum" = "FIVR_SS_6"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb index 3a1ae76..0157442 100644 --- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb @@ -37,7 +37,7 @@ register "fivr_spread_spectrum" = "FIVR_SS_6"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/riven/overridetree.cb b/src/mainboard/google/brya/variants/riven/overridetree.cb index 6f8db3c..359c427 100644 --- a/src/mainboard/google/brya/variants/riven/overridetree.cb +++ b/src/mainboard/google/brya/variants/riven/overridetree.cb @@ -25,7 +25,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/rull/overridetree.cb b/src/mainboard/google/brya/variants/rull/overridetree.cb index 3c04da5..77c85b2 100644 --- a/src/mainboard/google/brya/variants/rull/overridetree.cb +++ b/src/mainboard/google/brya/variants/rull/overridetree.cb @@ -13,7 +13,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "true" diff --git a/src/mainboard/google/brya/variants/sundance/overridetree.cb b/src/mainboard/google/brya/variants/sundance/overridetree.cb index 03450d4..8782f5d 100644 --- a/src/mainboard/google/brya/variants/sundance/overridetree.cb +++ b/src/mainboard/google/brya/variants/sundance/overridetree.cb @@ -10,7 +10,7 @@
chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb index 13d8836..964d833 100644 --- a/src/mainboard/google/brya/variants/taeko/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb @@ -53,7 +53,7 @@ register "usb2_phy_sus_pg_disable" = "1"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb index bbaa0ca..2dc3287 100644 --- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb @@ -40,7 +40,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb index 807f40a..ebe5853 100644 --- a/src/mainboard/google/brya/variants/taniks/overridetree.cb +++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb @@ -41,7 +41,7 @@ register "usb2_phy_sus_pg_disable" = "1"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/telith/overridetree.cb b/src/mainboard/google/brya/variants/telith/overridetree.cb index cac770f..8784e2f 100644 --- a/src/mainboard/google/brya/variants/telith/overridetree.cb +++ b/src/mainboard/google/brya/variants/telith/overridetree.cb @@ -21,7 +21,7 @@ register "sagv" = "SaGv_Enabled"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/xol/overridetree.cb b/src/mainboard/google/brya/variants/xol/overridetree.cb index 71e89de..69209fa 100644 --- a/src/mainboard/google/brya/variants/xol/overridetree.cb +++ b/src/mainboard/google/brya/variants/xol/overridetree.cb @@ -15,7 +15,7 @@ }"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/zydron/overridetree.cb b/src/mainboard/google/brya/variants/zydron/overridetree.cb index b02cb07..0acf490 100644 --- a/src/mainboard/google/brya/variants/zydron/overridetree.cb +++ b/src/mainboard/google/brya/variants/zydron/overridetree.cb @@ -36,7 +36,7 @@ register "pmc_gpe0_dw1" = "GPP_D"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index e79cf8c..d46d7c9 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -97,7 +97,7 @@ # slew rate for IA Domain: Fast/8 # slew rate for GT Domain: Fast/8 # Ignore slew rate configuration for SA Domain - register "enable_acoustic_noise_mitigation" = "1" + register "enable_acoustic_noise_mitigation" = "true" register "disable_fast_pkgc_ramp[VR_DOMAIN_IA]" = "1" register "slow_slew_rate_config[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "disable_fast_pkgc_ramp[VR_DOMAIN_GT]" = "1" diff --git a/src/mainboard/prodrive/atlas/devicetree.cb b/src/mainboard/prodrive/atlas/devicetree.cb index baca59d..9afdda5 100644 --- a/src/mainboard/prodrive/atlas/devicetree.cb +++ b/src/mainboard/prodrive/atlas/devicetree.cb @@ -31,7 +31,7 @@ }"
# Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1"
-
Elyes Haouas (Code Review)