David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29744 )
Change subject: util/cbfstool: Add optional argument ibb
......................................................................
Patch Set 21:
Hi Patrick & Philipp,
I'd like to see these patches get merged soon. Do you have any strong opinions on the short option for this patch? I think -O is an awkward choice, but I don't think it's important enough to block the patch. An alternative approach might be to use the long option only. That way we preserve short options for commands that are more likely to be invoked by users at the command-line (I assume this option will only be used in scripts).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29744
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb4857c894b9ee1edc464c0a1216cdda29937bbd
Gerrit-Change-Number: 29744
Gerrit-PatchSet: 21
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Amol N Sukerkar
amol.n.sukerkar@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jens Drenhaus
jens.drenhaus@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kai Michaelis
kai.michaelis@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Oct 2019 19:03:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment