Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Zhuohao Lee, Aaron Durbin, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56515 )
Change subject: mb/google/brya: create dynamic power limits mechanism for thermal
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Patchset:
PS8:
Looks pretty good, one last nit 😊
File src/mainboard/google/brya/variants/baseboard/brya/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56515/comment/cea738ae_44b68965
PS8, Line 34: config->controls.power_limits.pl1.min_power =
nit: This might get cleaner if we break out power_limits into a local variable, e.g.:
```
if (mchid == limits[i].mchid) {
struct dptf_power_limits *settings = &config->controls.power_limits;
settings->pl1.min_power = limits[i].pl1_min_power;
settings->pl1.max_power = limits[i].pl1_max_power;
...
```
then these should fit in a single line without a line-break needed and it is a little easier to read
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56515
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86619516adeec13642f02ba7faf9fc4945ad774e
Gerrit-Change-Number: 56515
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 06 Aug 2021 15:36:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment