Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Zhuohao Lee, Aaron Durbin, Karthik Ramasubramanian.

Patch set 8:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #8:

    Looks pretty good, one last nit 😊

• File src/mainboard/google/brya/variants/baseboard/brya/ramstage.c:

  • Patch Set #8, Line 34: config->controls.power_limits.pl1.min_power =

    nit: This might get cleaner if we break out power_limits into a local variable, e.g.:
    ```
    if (mchid == limits[i].mchid) {
           struct dptf_power_limits *settings = &config->controls.power_limits;
           settings->pl1.min_power = limits[i].pl1_min_power;
           settings->pl1.max_power = limits[i].pl1_max_power;
           ...
    ```
    then these should fit in a single line without a line-break needed and it is a little easier to read

To view, visit change 56515. To unsubscribe, or for help writing mail filters, visit settings.