Change in ...coreboot[master]: arch/x86/assembly_entry: Enable long mode on x86_64

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30114 )

Change subject: arch/x86/assembly_entry: Enable long mode on x86_64
......................................................................

Patch Set 12:

(3 comments)

https://review.coreboot.org/#/c/30114/11/src/arch/x86/long_mode.S 
File src/arch/x86/long_mode.S:

https://review.coreboot.org/#/c/30114/11/src/arch/x86/long_mode.S@86 
PS11, Line 86: 	or	%esi, 0x0(%edi)
> Repeated line. […]

Done

https://review.coreboot.org/#/c/30114/11/src/arch/x86/long_mode.S@90 
PS11, Line 90: 	cmp	$(4), %eax
> I may be overzealous here, but counting downwards is slightly faster and easier to understand.

Done

https://review.coreboot.org/#/c/30114/11/src/arch/x86/long_mode.S@194 
PS11, Line 194: 	cmpq	$(4), %rax
> As above.

Done