Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79852?usp=email )
Change subject: nb/amd/pi/00730F01/state_machine: re-enable LPC decodes ......................................................................
nb/amd/pi/00730F01/state_machine: re-enable LPC decodes
The AmdInitReset entry point of binaryPI disables the LPC decodes for the serial ports' IO ports causing the serial console output to stop after this entry point is called until the decodes are re-enabled in ramstage when the resource enablement is done. This patch re-enables the LPC IO decoding for the serial ports right after binaryPI disabled it to get the full log on the serial console.
TEST=Now the full console output from the APU2 board gets printed on the serial console.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I91ef4423bd7bf6c1d7a175336f0f89479f2cde02 --- M src/northbridge/amd/pi/00730F01/state_machine.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/79852/1
diff --git a/src/northbridge/amd/pi/00730F01/state_machine.c b/src/northbridge/amd/pi/00730F01/state_machine.c index 5f27fbb..6832064 100644 --- a/src/northbridge/amd/pi/00730F01/state_machine.c +++ b/src/northbridge/amd/pi/00730F01/state_machine.c @@ -10,6 +10,7 @@ #include <northbridge/amd/agesa/state_machine.h> #include <northbridge/amd/agesa/agesa_helper.h> #include <northbridge/amd/nb_common.h> +#include <southbridge/amd/pi/hudson/hudson.h>
void platform_BeforeInitReset(struct sysinfo *cb, AMD_RESET_PARAMS *Reset) { @@ -17,6 +18,8 @@
void platform_AfterInitReset(struct sysinfo *cb, AMD_RESET_PARAMS *Reset) { + /* re-enable LPC decodes for serial ports after AmdInitReset disabled those */ + hudson_lpc_decode(); }
void platform_BeforeInitEarly(struct sysinfo *cb, AMD_EARLY_PARAMS *Early)