Attention is currently required from: Maximilian Brune.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86580?usp=email )
Change subject: cpu/x86/64bit: Allow to map more of the address space
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/64bit/pt1G.S:
https://review.coreboot.org/c/coreboot/+/86580/comment/760fd906_aaf1209b?usp... :
PS1, Line 23: .rept (CONFIG_CPU_PT_ROM_MAP_GB + 511) / 512
It might be time for a comment now. Maybe something like: […]
It points to every PDPT entry in the specified address space. But there's only one PDPT for every 512GiB of memory.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86580?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If669426f2b5ae40dd5c62e17f3a0234783b7d462
Gerrit-Change-Number: 86580
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 17:47:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com