HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32496
Change subject: nb/intel/pineview: Use system_reset() ......................................................................
nb/intel/pineview: Use system_reset()
Use already defined system_reset() function.
Change-Id: I32c731de0c30940d15fd01fec6f10b3b33c04370 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/pineview/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/32496/1
diff --git a/src/northbridge/intel/pineview/romstage.c b/src/northbridge/intel/pineview/romstage.c index 7714344..bdb685b 100644 --- a/src/northbridge/intel/pineview/romstage.c +++ b/src/northbridge/intel/pineview/romstage.c @@ -22,6 +22,7 @@ #include <console/console.h> #include <device/pci_ops.h> #include <cbmem.h> +#include <cf9_reset.h> #include <halt.h> #include <romstage_handoff.h> #include <southbridge/intel/i82801gx/i82801gx.h> @@ -113,8 +114,7 @@
if (!cbmem_was_initted && s3resume) { /* Failed S3 resume, reset to come up cleanly */ - outb(0x6, 0xcf9); - halt(); + system_reset(); }
romstage_handoff_init(s3resume);
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32496 )
Change subject: nb/intel/pineview: Use system_reset() ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32496 )
Change subject: nb/intel/pineview: Use system_reset() ......................................................................
nb/intel/pineview: Use system_reset()
Use already defined system_reset() function.
Change-Id: I32c731de0c30940d15fd01fec6f10b3b33c04370 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32496 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/northbridge/intel/pineview/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/northbridge/intel/pineview/romstage.c b/src/northbridge/intel/pineview/romstage.c index 7714344..bdb685b 100644 --- a/src/northbridge/intel/pineview/romstage.c +++ b/src/northbridge/intel/pineview/romstage.c @@ -22,6 +22,7 @@ #include <console/console.h> #include <device/pci_ops.h> #include <cbmem.h> +#include <cf9_reset.h> #include <halt.h> #include <romstage_handoff.h> #include <southbridge/intel/i82801gx/i82801gx.h> @@ -113,8 +114,7 @@
if (!cbmem_was_initted && s3resume) { /* Failed S3 resume, reset to come up cleanly */ - outb(0x6, 0xcf9); - halt(); + system_reset(); }
romstage_handoff_init(s3resume);
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)