Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84930?usp=email )
Change subject: soc/mediatek/mt8196: Add SPI driver support ......................................................................
Patch Set 6:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84930/comment/b38b94e8_a5f064df?usp... : PS1, Line 9: controlleer
controller
Done
https://review.coreboot.org/c/coreboot/+/84930/comment/7dc3d275_adf77636?usp... : PS1, Line 10:
Mention that 8 busses are supported?
Done
https://review.coreboot.org/c/coreboot/+/84930/comment/dfedc682_426af742?usp... : PS1, Line 11: Test=Build pass
When will it be run time tested? Any new log messages?
There is no new logs. I have added SPI verification to the TEST. It can be tested with CB:84931.
File src/soc/mediatek/mt8196/include/soc/spi.h:
https://review.coreboot.org/c/coreboot/+/84930/comment/64a54eba_d2250111?usp... : PS3, Line 8: #ifndef __SOC_MEDIATEK_MT8196_SPI_H__
Why change it? The code in mediatek/ is already inconsistent.
Done
https://review.coreboot.org/c/coreboot/+/84930/comment/d2f36b31_7cf0fed1?usp... : PS3, Line 15: x
`(x)`
Done
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/84930/comment/edad32cd_1120a8aa?usp... : PS1, Line 123: unsigned int
size_t
Done
File src/soc/mediatek/mt8196/spi.c:
https://review.coreboot.org/c/coreboot/+/84930/comment/56d75f87_2770a571?usp... : PS3, Line 123: SPI_BUS_NUMBER
`ARRAY_SIZE(pad_funcs[0])` […]
Done
-
Jarried Lin (Code Review)