Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/16308 )
Change subject: drivers/intel/fsp2_0: Make FSP Headers Consumable out of Box
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/16308/15/src/drivers/intel/fsp2_0/i...
File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h:
https://review.coreboot.org/c/coreboot/+/16308/15/src/drivers/intel/fsp2_0/i...
PS15, Line 20: /*
: * This file is a implementation specific header. i.e. different
: * FSP implementations for different chipsets.
: */
Does anybody know what this comment refers to? It does neither apply to […]
This sounds like something I wrote, but I think this was copied from a different approach. The binding is done through -Iincludes where it's finding Base.h as well as the FSP headers pulling the headers that supply appropriate types. The issue is that FSP implementations had a dependency on specific edk2 headers so there wasn't just one edk2 version to bind to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/16308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10739dca1b6da3f15bd850adf06238f7c51508f7
Gerrit-Change-Number: 16308
Gerrit-PatchSet: 15
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 12 Jan 2020 18:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment