Attention is currently required from: Jason Glenesk, Marshall Dawson, Felix Held. Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50999 )
Change subject: mb/amd,google: Rename static functions to mainboard_enable ......................................................................
mb/amd,google: Rename static functions to mainboard_enable
Let's not have 7 boards of all use a different name for the .enable_dev function in mainboard chip_operations.
Change-Id: I07f3569e6af85f4f1635595125fe2881ab9ddd43 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/amd/bilby/mainboard.c M src/mainboard/amd/gardenia/mainboard.c M src/mainboard/amd/majolica/mainboard.c M src/mainboard/amd/mandolin/mainboard.c M src/mainboard/amd/padmelon/mainboard.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/zork/mainboard.c 7 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/50999/1
diff --git a/src/mainboard/amd/bilby/mainboard.c b/src/mainboard/amd/bilby/mainboard.c index 2bfdb59..7e3c17b 100644 --- a/src/mainboard/amd/bilby/mainboard.c +++ b/src/mainboard/amd/bilby/mainboard.c @@ -95,7 +95,7 @@ mainboard_program_emmc_gpios(); }
-static void bilby_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
@@ -106,5 +106,5 @@
struct chip_operations mainboard_ops = { .init = mainboard_init, - .enable_dev = bilby_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/gardenia/mainboard.c b/src/mainboard/amd/gardenia/mainboard.c index 60739db..e153f71 100644 --- a/src/mainboard/amd/gardenia/mainboard.c +++ b/src/mainboard/amd/gardenia/mainboard.c @@ -75,7 +75,7 @@ /************************************************* * enable the dedicated function in gardenia board. *************************************************/ -static void gardenia_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -86,5 +86,5 @@
struct chip_operations mainboard_ops = { .init = mainboard_init, - .enable_dev = gardenia_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/majolica/mainboard.c b/src/mainboard/amd/majolica/mainboard.c index 145ed64..7538ca9 100644 --- a/src/mainboard/amd/majolica/mainboard.c +++ b/src/mainboard/amd/majolica/mainboard.c @@ -85,7 +85,7 @@ picr_data_ptr = fch_pic_routing; }
-static void majolica_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
@@ -95,5 +95,5 @@ }
struct chip_operations mainboard_ops = { - .enable_dev = majolica_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/mandolin/mainboard.c b/src/mainboard/amd/mandolin/mainboard.c index 3513f61..915f22e 100644 --- a/src/mainboard/amd/mandolin/mainboard.c +++ b/src/mainboard/amd/mandolin/mainboard.c @@ -95,7 +95,7 @@ mainboard_program_emmc_gpios(); }
-static void mandolin_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
@@ -106,5 +106,5 @@
struct chip_operations mainboard_ops = { .init = mainboard_init, - .enable_dev = mandolin_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/amd/padmelon/mainboard.c b/src/mainboard/amd/padmelon/mainboard.c index 1ffa16e..fc5279b 100644 --- a/src/mainboard/amd/padmelon/mainboard.c +++ b/src/mainboard/amd/padmelon/mainboard.c @@ -104,7 +104,7 @@ /************************************************* * enable the dedicated function in padmelon board. *************************************************/ -static void padmelon_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -115,5 +115,5 @@
struct chip_operations mainboard_ops = { .init = mainboard_init, - .enable_dev = padmelon_enable, + .enable_dev = mainboard_enable, }; diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 570f20c..b69af78 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -148,7 +148,7 @@ /************************************************* * Dedicated mainboard function *************************************************/ -static void kahlee_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); @@ -176,7 +176,7 @@
struct chip_operations mainboard_ops = { .init = mainboard_init, - .enable_dev = kahlee_enable, + .enable_dev = mainboard_enable, };
/* Variants may override these functions so see definitions in variants/ */ diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index 06f4e8d..31d87c0 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -197,7 +197,7 @@ /************************************************* * Dedicated mainboard function *************************************************/ -static void zork_enable(struct device *dev) +static void mainboard_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n");
@@ -217,7 +217,7 @@
struct chip_operations mainboard_ops = { .init = mainboard_init, - .enable_dev = zork_enable, + .enable_dev = mainboard_enable, .final = mainboard_final, };
-
Kyösti Mälkki (Code Review)