Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons, Jianjun Wang.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56794 )
Change subject: libpayload/pci: Add PCIe interfaces for MediaTek platform
......................................................................
Patch Set 38:
(3 comments)
File payloads/libpayload/drivers/pcie_mediatek.c:
https://review.coreboot.org/c/coreboot/+/56794/comment/d4cdfa91_64b7d90a
PS38, Line 22: pcie_base = base;
The base address can be stored in the coreboot table. We may need to wait for CB:57614 (or you can create a similar patch).
https://review.coreboot.org/c/coreboot/+/56794/comment/694e5d23_528e5b58
PS38, Line 29: & 0x7
Already included in the macro.
https://review.coreboot.org/c/coreboot/+/56794/comment/273f9af1_455ae28f
PS38, Line 29: & 0x1f
Already included in the macro.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ea7d111fed6b816fa2352fe93c268116519a577
Gerrit-Change-Number: 56794
Gerrit-PatchSet: 38
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.com
Gerrit-Comment-Date: Wed, 30 Mar 2022 02:39:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment