Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie, Karthik Ramasubramanian. Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50005 )
Change subject: mb/google/guybrush: Lift baseboard into mainbord dir ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50005/comment/7a5fb950_971f8bf7 PS2, Line 7: guybrush
Isn't guybrush the name of one of the reference designs? In that case shouldn't the mainboard be nam […]
Yes guybrush is a reference. The project is "Monkey Island" should move all this into monkey_island instead?
Patchset:
PS2:
What you had before was correct. Please see zork layout as reference.
I changed it on purpose for several reasons.
* We have 2 reference designs that will need seperate baseboards and I did not want copy zork having separate gpio files in the same directory. * Seems that we should have a directory under baseboard for each reference board * Now we have paths that look like variants/baseboard/guybrush/... and variants/guybrush. Looking at that a baseboard is not a variant itself so why is it under the variants directory? * The other option is to split each reference into a mainboard which I considered but this seems like the most maintainable approach.
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/50005/comment/042bbaed_3f0e701f PS2, Line 33: variants
baseboard/ is intentionally placed under variants/ for all Chrome OS mainboards including zork. […]
See my first comment. If you would like I will do it the same as zork.
File src/mainboard/google/guybrush/baseboard/devicetree.cb:
PS2:
I think what you had before was correct. All you need to do is change the name from devicetree. […]
I know zork did it that way but I felt that is layout would be easier to maintain.
-
Mathew King (Code Review)