Attention is currently required from: Boris Mittelberg, Caveh Jalali, Julius Werner.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86379?usp=email )
Change subject: ec/google/chromeec: Add early power off support ......................................................................
Patch Set 1:
(1 comment)
File src/ec/google/chromeec/reset.c:
https://review.coreboot.org/c/coreboot/+/86379/comment/79530c77_5bf55b58?usp... : PS1, Line 8: google_chromeec_do_early_poweroff();
Actually, not sure this needs to be an extra file either. If you move the Kconfig `select` into `chromeec/Kconfig` as suggested on CB:86356, this will always be enabled anyway, so you might as well just put it in the main ec.c.
`HAVE_EARLY_POWEROFF_SUPPORT` cannot be moved to `chromeec/Kconfig` because the `platform_do_early_poweroff` API, declared in intelblocks/pmclib.h, is specific to Intel platforms and not available to other architectures (ARM, AMD) using E`C_GOOGLE_CHROMEEC`. To prevent header inclusion errors, platform_do_early_poweroff is implemented within a file controlled by HAVE_EARLY_POWEROFF_SUPPORT, limiting its current applicability to Intel platforms.
-
Subrata Banik (Code Review)