Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43560 )
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
mb/asrock/b85m_pro4: Enable VGA port
Now that libgfxinit has been fixed, trying to enable the Analog port no longer hangs the system, nor fills the monitor with unreadable garbage.
Tested with linear framebuffer on VGA only and VGA with a smaller HDMI monitor, in both cases all monitors work. Also works with legacy VGA.
Change-Id: Ie2f88edcb7ed1984adebf2af23195767af13654c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/gma-mainboard.ads 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/43560/1
diff --git a/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads b/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads index 49ca38c..393275b 100644 --- a/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads +++ b/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads @@ -11,8 +11,7 @@ ports : constant Port_List := (HDMI1, -- DVI-D HDMI3, -- HDMI - -- FIXME: Haswell VGA support in libgfxinit is broken - -- Analog, -- VGA + Analog, -- VGA others => Disabled);
end GMA.Mainboard;
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43560
to look at the new patch set (#3).
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
mb/asrock/b85m_pro4: Enable VGA port
Now that libgfxinit has been fixed, trying to enable the Analog port no longer hangs the system, nor fills the monitor with unreadable garbage.
Tested with linear framebuffer on VGA only and VGA with a smaller HDMI monitor, in both cases all monitors work. Also works with legacy VGA.
Change-Id: Ie2f88edcb7ed1984adebf2af23195767af13654c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/gma-mainboard.ads 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/43560/3
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43560 )
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG@12 PS3, Line 12: VGA with a smaller HDMI I was wondering if you used an adapter somehow, but I guess you mean two monitors?
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG@13 PS3, Line 13: legacy VGA Sorry, what is legacy VGA?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43560 )
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG@12 PS3, Line 12: VGA with a smaller HDMI
I was wondering if you used an adapter somehow, but I guess you mean two monitors?
Yes, two monitors. This is to test scaling (the monitor on VGA is larger, so the smaller framebuffer needs to be upscaled). I'll try to rephrase this a bit.
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG@13 PS3, Line 13: legacy VGA
Sorry, what is legacy VGA?
Legacy VGA text mode, the other option besides "linear high-resolution framebuffer" one can select when using libgfxinit. I can use "text mode" if that is clearer.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43560
to look at the new patch set (#4).
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
mb/asrock/b85m_pro4: Enable VGA port
Now that libgfxinit has been fixed, trying to enable the Analog port no longer hangs the system, nor fills the monitor with unreadable garbage.
Tested with linear framebuffer, displays correctly on a 1920x1080 VGA monitor. Scaling also works when a smaller HDMI monitor is connected as well. Legacy VGA text mode is also functional on either monitor, too.
Change-Id: Ie2f88edcb7ed1984adebf2af23195767af13654c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/gma-mainboard.ads 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/43560/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43560 )
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
Patch Set 4:
(2 comments)
a
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG@12 PS3, Line 12: VGA with a smaller HDMI
Yes, two monitors. […]
Done
https://review.coreboot.org/c/coreboot/+/43560/3//COMMIT_MSG@13 PS3, Line 13: legacy VGA
Legacy VGA text mode, the other option besides "linear high-resolution framebuffer" one can select w […]
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43560 )
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
Patch Set 7: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43560 )
Change subject: mb/asrock/b85m_pro4: Enable VGA port ......................................................................
mb/asrock/b85m_pro4: Enable VGA port
Now that libgfxinit has been fixed, trying to enable the Analog port no longer hangs the system, nor fills the monitor with unreadable garbage.
Tested with linear framebuffer, displays correctly on a 1920x1080 VGA monitor. Scaling also works when a smaller HDMI monitor is connected as well. Legacy VGA text mode is also functional on either monitor, too.
Change-Id: Ie2f88edcb7ed1984adebf2af23195767af13654c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43560 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asrock/b85m_pro4/gma-mainboard.ads 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads b/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads index 49ca38c..393275b 100644 --- a/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads +++ b/src/mainboard/asrock/b85m_pro4/gma-mainboard.ads @@ -11,8 +11,7 @@ ports : constant Port_List := (HDMI1, -- DVI-D HDMI3, -- HDMI - -- FIXME: Haswell VGA support in libgfxinit is broken - -- Analog, -- VGA + Analog, -- VGA others => Disabled);
end GMA.Mainboard;
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)