Marty E. Plummer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
3rdparty/ffs: add open-power ffs utils
These tools are used to manipulate open-power specific partitioning and ecc algorithms.
Change-Id: I0657f76aab75190244d0e81c2b1a525e50af484d Signed-off-by: Marty E. Plummer hanetzer@startmail.com --- M .gitmodules A 3rdparty/ffs 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/35007/1
diff --git a/.gitmodules b/.gitmodules index e18f0dc..ef323e9 100644 --- a/.gitmodules +++ b/.gitmodules @@ -34,3 +34,6 @@ url = ../intel-microcode.git update = none ignore = dirty +[submodule "3rdparty/ffs"] + path = 3rdparty/ffs + url = https://github.com/open-power/ffs diff --git a/3rdparty/ffs b/3rdparty/ffs new file mode 160000 index 0000000..3ec70fb --- /dev/null +++ b/3rdparty/ffs @@ -0,0 +1 @@ +Subproject commit 3ec70fbc458e32eef0d0b1de79688b4dc48cbd57
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
If we're going to add this, we probably don't want to pull it directly from github, we'd want to mirror it on the coreboot server like all of our other 3rdparty modules.
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules@39 PS1, Line 39: url = https://github.com/open-power/ffs Patrick, do we want to mirror this project?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules@39 PS1, Line 39: url = https://github.com/open-power/ffs
Patrick, do we want to mirror this project?
Generally speaking I have no objection. Practically speaking, we're growing lots and lots of submodules recently. Maybe we should mark more of them "update = none" and pull them in on demand only? (but that's a tangent to the issue at hands here)
Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules@39 PS1, Line 39: url = https://github.com/open-power/ffs
Generally speaking I have no objection. […]
yeah, if you guys mirror this I can redo this bit. I just needed something to work with for the moment.
Hello Timothy Pearson, build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35007
to look at the new patch set (#2).
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
3rdparty/ffs: add open-power ffs utils
These tools are used to manipulate open-power specific partitioning and ecc algorithms.
Change-Id: I0657f76aab75190244d0e81c2b1a525e50af484d Signed-off-by: Marty E. Plummer hanetzer@startmail.com --- M .gitmodules A 3rdparty/ffs 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/35007/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules@39 PS1, Line 39: url = https://github.com/open-power/ffs
yeah, if you guys mirror this I can redo this bit. I just needed something to […]
Done. The mirror is in place.
Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/35007/1/.gitmodules@39 PS1, Line 39: url = https://github.com/open-power/ffs
Done. The mirror is in place.
Done, changed the url if I did all the things right.
Timothy Pearson has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35007 )
Change subject: 3rdparty/ffs: add open-power ffs utils ......................................................................
3rdparty/ffs: add open-power ffs utils
These tools are used to manipulate open-power specific partitioning and ecc algorithms.
Change-Id: I0657f76aab75190244d0e81c2b1a525e50af484d Signed-off-by: Marty E. Plummer hanetzer@startmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35007 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M .gitmodules A 3rdparty/ffs 2 files changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/.gitmodules b/.gitmodules index e18f0dc..deb3cf0 100644 --- a/.gitmodules +++ b/.gitmodules @@ -34,3 +34,6 @@ url = ../intel-microcode.git update = none ignore = dirty +[submodule "3rdparty/ffs"] + path = 3rdparty/ffs + url = ../ffs.git diff --git a/3rdparty/ffs b/3rdparty/ffs new file mode 160000 index 0000000..3ec70fb --- /dev/null +++ b/3rdparty/ffs @@ -0,0 +1 @@ +Subproject commit 3ec70fbc458e32eef0d0b1de79688b4dc48cbd57
-
Martin Roth (Code Review) -
Marty E. Plummer (Code Review)
-
Patrick Georgi (Code Review)
-
Timothy Pearson (Code Review)