Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33954 )
Change subject: mb/google/hatch/variants: Touch pad no function ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33954/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/#/c/33954/3/src/mainboard/google/hatch/variants/... PS3, Line 37: PAD_CFG_GPI_APIC(GPP_A21, NONE, DEEP, LEVEL, NONE), Why is this change required? It is already done in baseboard/gpio.c
https://review.coreboot.org/#/c/33954/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/#/c/33954/3/src/mainboard/google/hatch/variants/... PS3, Line 2: # GPIO community PM configuration : register "gpio_pm[COMM_0]" = "0" : register "gpio_pm[COMM_1]" = "0" : register "gpio_pm[COMM_2]" = "0" : register "gpio_pm[COMM_3]" = "0" Did you try without this change to see if touchpad works?
-
Furquan Shaikh (Code Review)