Attention is currently required from: Marc Jones, John Looney, Jingle Hsu, Morgan Jang, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51276 )
Change subject: ipmi/ocp: Remove duplicate IPMI OEM command set processor information
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51276/comment/85072f9d_098de682
PS7, Line 12: Also this command has a higher chance to see BMC KCS timeout issue when
: coreboot log level is 4, which can be avoided if this command is run at
: a later stage such as LinuxBoot.
:
the downside is that by removing this here, every payload needs to replicate that behavior, no?
Yes you are right, but for OCP OSF projects currently we all use u-root payload, also because of the timeout issue it's possible that certain IPMI commands would be better suited to be done in the payload.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51276
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0081e5195cbd605e062723c197ac74343f79a13
Gerrit-Change-Number: 51276
Gerrit-PatchSet: 7
Gerrit-Owner: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: John Looney
john.looney@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: John Looney
john.looney@gmail.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Tue, 16 Mar 2021 00:47:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment