[S] Change in coreboot[main]: mb/google/brya: Do not select HAVE_ACPI_RESUME

[Dinesh Gehlot (Code Review)]

Attention is currently required from: Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel.

Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86422?usp=email )

Change subject: mb/google/brya: Do not select HAVE_ACPI_RESUME
......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/86422/comment/8f2163c2_77995043?usp... :
PS1, Line 9: no
> not

Acknowledged

https://review.coreboot.org/c/coreboot/+/86422/comment/16c825a9_ae5355c7?usp... :
PS1, Line 9: Brya mainboard does not reliably support S3 entry/exit.
> Why?

Its a configuration, system will not suspend to S3 but s0ix, enabling quicker resume. So S3 is no longer the default suspend state and is not supported on x86 platforms.

https://review.coreboot.org/c/coreboot/+/86422/comment/fc110b5f_a48d6d6f?usp... :
PS1, Line 10: Also trigger a fail-safe board
            : reset if the system resumes from S3.
> Please make this a separate commit. I also do not agree with this. […]

These changes are designed to work in conjunction and are best submitted as a single commit. Without the fail safe mechanism, the system could experience abnormalities if it enters the S3 state by any mean.

https://review.coreboot.org/c/coreboot/+/86422/comment/2d95bfe3_05743da5?usp... :
PS1, Line 15: asl
> ASL

Acknowledged