Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu, cong yang.
Paul Menzel has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/86640?usp=email )
Change subject: mb/google/geralt: Adjust VSP/VSN voltage for CSOT_PNA957QT1_1 panel
......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86640/comment/7c7abed0_d96f1f45?usp... :
PS3, Line 15: TEST=Boot to firmware screen
To the recovery screen?
Did it not work before?
File src/mainboard/google/geralt/panel_ciri.c:
https://review.coreboot.org/c/coreboot/+/86640/comment/3230d101_8aff4c65?usp... :
PS3, Line 11: val
Maybe more descriptive: voltage_reg_val or so?
https://review.coreboot.org/c/coreboot/+/86640/comment/46176276_5cd16144?usp... :
PS3, Line 30: default
Name it 5_7V or so?
https://review.coreboot.org/c/coreboot/+/86640/comment/e81f381c_1e19eda8?usp... :
PS3, Line 32: 0x11
Please define macros for this.
https://review.coreboot.org/c/coreboot/+/86640/comment/9c820ce8_b40fc2dd?usp... :
PS3, Line 35: csot
Name it 6V?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86640?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1b69303317f5ef47818f4a6a0c851bf650285e51
Gerrit-Change-Number: 86640
Gerrit-PatchSet: 3
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xinxiong Xu
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: cong yang
yangcong5@huaqin.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sun, 02 Mar 2025 09:30:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No