Attention is currently required from: Tarun Tuli, Eran Mitrani, Kapil Porwal, Nick Vaccaro.
Hello build bot (Jenkins), Tarun Tuli, Eran Mitrani, Subrata Banik, Nick Vaccaro, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69970
to look at the new patch set (#3).
Change subject: {soc/intel/cmn/pcie, mb/google/volteer}: Rename `is_external` variable ......................................................................
{soc/intel/cmn/pcie, mb/google/volteer}: Rename `is_external` variable
Name a variable based on its utility. `is_external` variable adds `ExternalFacingPort` _DSD property to an ACPI device hence rename it to `add_acpi_external_facing_port`.
BUG=b:259716145 TEST=Build google/rex with this flag and verify it in SSDT at runtime.
SSDT snippet: Name (_DSD, Package (0x04) // _DSD: Device-Specific Data { ToUUID ("6211e2c0-58a3-4af3-90e1-927a4e0c55a4"), Package (0x01) { Package (0x02) { "HotPlugSupportInD3", One } },
ToUUID ("efcc06cc-73ac-4bc3-bff0-76143807c389"), Package (0x01) { Package (0x02) { "ExternalFacingPort", One } } })
Signed-off-by: Kapil Porwal kapilporwal@google.com Change-Id: I65100283ed9b65037c9890f28ecab41fcfa25d83 --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/soc/intel/common/block/pcie/rtd3/chip.h M src/soc/intel/common/block/pcie/rtd3/rtd3.c 3 files changed, 45 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/69970/3