Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner, Prasad Malisetty, mturney mturney. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 22:
(1 comment)
File src/soc/qualcomm/sc7280/pcie_host.c:
https://review.coreboot.org/c/coreboot/+/53902/comment/ccd6d323_ddb6877e PS22, Line 1139: setup_pcie_host This change is duplicating the logic for training, scanning, assigning resources that is already provided by common code in coreboot. Please see device/pci_device.c, device/device.c, etc. on how this is handled. Examples of how SoCs currently use this common code support is any Intel/AMD platform. See `pci_domain_ops` to see how the different hooks are provided to read/set/scan/enable resources. You are going to need something similar for qualcomm SoC as well i.e. proper device operations that will use the hooks provided by the common code such that qualcomm controller specific work is provided by the SoC-specific code while making use of the common code for performing the standard PCIe operations. If you find something that is currently not provided in the common hooks,it would be helpful if you can outline the limitation. We can work on enabling the required support to ensure that we do not have to duplicate the entire scan/train/assign support in the SoC.
-
Furquan Shaikh (Code Review)