Change in coreboot[master]: soc/intel/tigerlake: Publish EMMC and SD card ACPI devices for Jasper...
Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/tigerlake: Publish EMMC and SD card ACPI devices for Jasper Lake ......................................................................
soc/intel/tigerlake: Publish EMMC and SD card ACPI devices for Jasper Lake
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I70d47455c48990afe9e79c013c5272d70f4f71e7 --- M src/soc/intel/tigerlake/acpi/southbridge.asl 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39582/1
diff --git a/src/soc/intel/tigerlake/acpi/southbridge.asl b/src/soc/intel/tigerlake/acpi/southbridge.asl index 8593d07..8786251 100644 --- a/src/soc/intel/tigerlake/acpi/southbridge.asl +++ b/src/soc/intel/tigerlake/acpi/southbridge.asl @@ -49,5 +49,10 @@ /* USB XHCI 0:14.0 */ #include "xhci.asl"
+#if CONFIG(SOC_INTEL_JASPERLAKE) +/* SD card and EMMC */ +#include "scs.asl" +#endif + /* PCI _OSC */ #include <soc/intel/common/acpi/pci_osc.asl>
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39582
to look at the new patch set (#2).
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
soc/intel/jasperlake: Publish EMMC and SD card ACPI devices
Signed-off-by: Aamir Bohra aamir.bohra@intel.com Change-Id: I70d47455c48990afe9e79c013c5272d70f4f71e7 --- M src/soc/intel/jasperlake/acpi/southbridge.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39582/2
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 2: Code-Review+2
Ronak Kanabar has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Removed Code-Review+2 by Ronak Kanabar ronak.kanabar@intel.com
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG@8 PS2, Line 8: BUG and any TEST info.
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG@9 PS2, Line 9: Signed-off-by: Aamir Bohra aamir.bohra@intel.com Nit: Move this line below Change-Id line.
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Ronak Kanabar, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39582
to look at the new patch set (#3).
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
soc/intel/jasperlake: Publish EMMC and SD card ACPI devices
BUG=b:150872580 TEST=Build waddledoo board. Verify EMMC and SD card ACPI devices are present in dsdt.asl.
Change-Id: I70d47455c48990afe9e79c013c5272d70f4f71e7 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/jasperlake/acpi/southbridge.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39582/3
Hello build bot (Jenkins), Furquan Shaikh, Maulik V Vaghela, Ronak Kanabar, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39582
to look at the new patch set (#4).
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
soc/intel/jasperlake: Publish EMMC and SD card ACPI devices
BUG=b:150872580 TEST=Build waddledoo board. Verify EMMC and SD card ACPI devices are present in dsdt.asl.
Change-Id: I70d47455c48990afe9e79c013c5272d70f4f71e7 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/jasperlake/acpi/southbridge.asl 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/39582/4
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG@8 PS2, Line 8:
BUG and any TEST info.
Done. Added.
https://review.coreboot.org/c/coreboot/+/39582/2//COMMIT_MSG@9 PS2, Line 9: Signed-off-by: Aamir Bohra aamir.bohra@intel.com
Nit: Move this line below Change-Id line.
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 4: Code-Review+2
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 4: Code-Review+2
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 4: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
soc/intel/jasperlake: Publish EMMC and SD card ACPI devices
BUG=b:150872580 TEST=Build waddledoo board. Verify EMMC and SD card ACPI devices are present in dsdt.asl.
Change-Id: I70d47455c48990afe9e79c013c5272d70f4f71e7 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39582 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/jasperlake/acpi/southbridge.asl 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Maulik V Vaghela: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/acpi/southbridge.asl b/src/soc/intel/jasperlake/acpi/southbridge.asl index 6329340..c0674a0e 100644 --- a/src/soc/intel/jasperlake/acpi/southbridge.asl +++ b/src/soc/intel/jasperlake/acpi/southbridge.asl @@ -59,3 +59,6 @@
/* PMC Core*/ #include <soc/intel/common/block/acpi/acpi/pmc.asl> + +/* EMMC/SD card */ +#include "scs.asl"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39582 )
Change subject: soc/intel/jasperlake: Publish EMMC and SD card ACPI devices ......................................................................
Patch Set 5:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/2251 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2250 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/2249
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aamir Bohra (Code Review)
-
Furquan Shaikh (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Ronak Kanabar (Code Review)
-
Subrata Banik (Code Review)