Attention is currently required from: Jarried Lin, Yidi Lin, Yu-Ping Wu.
Chhao Chang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )
Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock
......................................................................
Patch Set 17:
(4 comments)
Patchset:
PS14:
gental ping
Done
File src/soc/mediatek/common/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/1a6192de_57598eb5?usp... :
PS14, Line 10: 0x880
Please abandon.
Done
File src/soc/mediatek/mt8196/eint_event.c:
https://review.coreboot.org/c/coreboot/+/84025/comment/f74f591f_9ab83780?usp... :
PS14, Line 16: static void eint_clear_event_mask(uintptr_t base, unsigned int port_num)
The folder pach will be removed and will be implemented on the kernel side
Done
https://review.coreboot.org/c/coreboot/+/84025/comment/7f354067_04a45098?usp... :
PS14, Line 26: eint_clear_event_mask(EINT_E_BASE, MAX_E);
The folder pach will be removed and will be implemented on the kernel side
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84025?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4bf3820a89172186b8f51591f8760787affbb7a3
Gerrit-Change-Number: 84025
Gerrit-PatchSet: 17
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Chhao Chang
ot_chhao.chang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 02:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chhao Chang
ot_chhao.chang@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com