Attention is currently required from: Cliff Huang, Jérémy Compostella, Lance Zhao, Nico Huber, Tim Wawrzynczak.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email )
Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82642/comment/6fc3031d_d2803336?usp... :
PS1, Line 7: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
Why? […]
hmm, that's a good point that i didn't think about. since only one soc selects ACPI_NO_PCAT_8259, removing that one and having all other socs select ACPI_HAVE_PCAT_8259 isn't a good option either, so maybe it would be best to just keep some slight duplication in the kconfig. i'll rebase this one on top of the other two patches to land those two; don't have a super strong opinion on whether to drop this one or not
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82642?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2
Gerrit-Change-Number: 82642
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Mon, 27 May 2024 12:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de