Attention is currently required from: Jérémy Compostella, Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86400?usp=email )
Change subject: drivers/usb/acpi: Account for GPIO polarity
......................................................................
Patch Set 11:
(1 comment)
File src/drivers/usb/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/86400/comment/faf3ef84_c4e413c7?usp... :
PS7, Line 95: void acpi_device_intel_bt_common(const struct acpi_gpio *reset_gpio,
: const struct acpi_gpio *enable_gpio);
The variable order used to be enable_gpio and reset_gpio. Now this is reset_gpio and enable_gpio. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86400?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib481d49d536b702fef149af882209501c61de6da
Gerrit-Change-Number: 86400
Gerrit-PatchSet: 11
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Wed, 19 Feb 2025 08:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com