Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73319 )
Change subject: soc/amd/picasso/acpi: use ACPI_SCI_IRQ definition ......................................................................
soc/amd/picasso/acpi: use ACPI_SCI_IRQ definition
Since there's a define for the ACPI_SCI_IRQ 9, use the define instead of a magic number in the code.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I23c8f62929f3f66192698e10826d10329ef3d8cc --- M src/soc/amd/picasso/acpi.c 1 file changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/73319/1
diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index 081ed10..24ec393 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -44,7 +44,7 @@ MP_IRQ_TRIGGER_DEFAULT | MP_IRQ_POLARITY_DEFAULT); /* SCI IRQ type override */ current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, - MP_BUS_ISA, 9, 9, + MP_BUS_ISA, ACPI_SCI_IRQ, ACPI_SCI_IRQ, MP_IRQ_TRIGGER_LEVEL | MP_IRQ_POLARITY_LOW);
current = acpi_fill_madt_irqoverride(current); @@ -62,7 +62,7 @@
printk(BIOS_DEBUG, "pm_base: 0x%04x\n", ACPI_IO_BASE);
- fadt->sci_int = 9; /* IRQ 09 - ACPI SCI */ + fadt->sci_int = ACPI_SCI_IRQ;
if (permanent_smi_handler()) { fadt->smi_cmd = APM_CNT;