Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Kane Chen (Code Review)

17 May 2019 17 May '19

1:02 a.m.

Kane Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32845

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset ......................................................................

mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset

Currently, GPP_H0 gpio input rout is set to GPI_INT. So, ACPI_GPIO_IRQ is required for GPP_H0 in devicetree This change also aligns hatch's setting.

Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Signed-off-by: Kane Chen kane.chen@intel.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/32845/1

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 9546420..042c6b0 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -90,7 +90,7 @@ chip drivers/i2c/da7219 # TODO: these settings were copied from another board # with the same chip. verify the settings - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_H0_IRQ)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_H0_IRQ)" register "btn_cfg" = "50" register "mic_det_thr" = "500" register "jack_ins_deb" = "20"

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Kane Chen (Code Review)

17 May 17 May

1:04 a.m.

Kane Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset ......................................................................

mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset

Currently, GPP_H0 gpio input rout is set to GPI_INT. So, ACPI_GPIO_IRQ is required for GPP_H0 in devicetree This change also aligns hatch's setting.

BUG=b:131742713 TEST=headset is working

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/32845/2

Kane Chen (Code Review)

1:14 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Hello Seunghwan Kim, Naveen M, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32845

to look at the new patch set (#3).

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Currently, GPP_H0 gpio input rout is set to GPI_INT. So, ACPI_GPIO_IRQ is required for GPP_H0 in devicetree This change also aligns hatch's setting.

BUG=b:131742713 TEST=headset is working

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/32845/3

SH Kim (Code Review)

1:21 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 May 2019 08:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Naveen M (Code Review)

1:22 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Naveen M has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 May 2019 08:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ben Kao (Code Review)

2:01 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 3: Code-Review+1

test with headset is OK.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 17 May 2019 09:01:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ben Kao (Code Review)

20 May 20 May

1:17 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 3: -Code-Review

(1 comment)

https://review.coreboot.org/#/c/32845/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:

https://review.coreboot.org/#/c/32845/3/src/mainboard/google/hatch/variants/... PS3, Line 93: GPP_H0_IRQ it should be "GPP_H0", right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 3 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 May 2019 08:17:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Kane Chen (Code Review)

1:23 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Hello Seunghwan Kim, Ben Kao, SH Kim, Naveen M, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32845

to look at the new patch set (#4).

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Currently, GPP_H0 gpio input rout is set to GPI_INT. So, ACPI_GPIO_IRQ is required for GPP_H0 in devicetree This change also aligns hatch's setting.

BUG=b:131742713 TEST=headset is working

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/32845/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Kane Chen (Code Review)

1:28 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32845/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/kohaku/overridetree.cb:

https://review.coreboot.org/#/c/32845/3/src/mainboard/google/hatch/variants/... PS3, Line 93: GPP_H0_IRQ

...

it should be "GPP_H0", right?

thanks for capturing this. Could you kindly help to very the new change?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 May 2019 08:28:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ben Kao ben.kao@intel.com Gerrit-MessageType: comment

Ben Kao (Code Review)

2:08 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 4: Code-Review+1

I have verified, it works.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 20 May 2019 09:08:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:54 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 May 2019 16:54:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

9:56 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 May 2019 16:56:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9:57 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 20 May 2019 16:57:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

21 May 21 May

2:29 a.m.

New subject: Change in ...coreboot[master]: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32845 )

Change subject: mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT ......................................................................

mb/google/kohaku: Set ACPI_GPIO_IRQ_EDGE_BOTH for headset INT

Currently, GPP_H0 gpio input rout is set to GPI_INT. So, ACPI_GPIO_IRQ is required for GPP_H0 in devicetree This change also aligns hatch's setting.

BUG=b:131742713 TEST=headset is working

Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Signed-off-by: Kane Chen kane.chen@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32845 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Ben Kao ben.kao@intel.com Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve Ben Kao: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 9546420..69875bd 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -90,7 +90,7 @@ chip drivers/i2c/da7219 # TODO: these settings were copied from another board # with the same chip. verify the settings - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_H0_IRQ)" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_H0)" register "btn_cfg" = "50" register "mic_det_thr" = "500" register "jack_ins_deb" = "20"

-- To view, visit https://review.coreboot.org/c/coreboot/+/32845 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1264641bc4dfa5f98b6dab2d6f2133a6f9cbdb8 Gerrit-Change-Number: 32845 Gerrit-PatchSet: 5 Gerrit-Owner: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Ben Kao ben.kao@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Kane Chen kane.chen@intel.com Gerrit-Reviewer: Naveen M naveen.m@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com Gerrit-Reviewer: Seunghwan Kim sh_.kim@samsung.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

2006

days inactive

2010

days old

coreboot-gerrit@coreboot.org

13 comments

8 participants

tags (0)

participants (8)

Ben Kao (Code Review)
Furquan Shaikh (Code Review)
Kane Chen (Code Review)
Naveen M (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
SH Kim (Code Review)
Tim Wawrzynczak (Code Review)