[XS] Change in coreboot[main]: mb/google/trulo: Update GPIO wake pins - coreboot-gerrit

21 Feb 2025


      Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86555?usp=email )
Change subject: mb/google/trulo: Update GPIO wake pins
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/trulo/gpio.c:
https://review.coreboot.org/c/coreboot/+/86555/comment/460fb570_9566948b?usp... :
PS2, Line 245: 	PAD_CFG_GPI_IRQ_WAKE_LOCK(GPP_F17, NONE, EDGE_SINGLE, INVERT, LOCK_CONFIG),
this should move into a separate CL as you are locking down the EC wake PIN
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86555?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I055a60476e4a37bf74940802157bb9cd30bac3c4
Gerrit-Change-Number: 86555
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eric Lai ericllai@google.com
Gerrit-Reviewer: Jayvik Desai jayvik@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai jayvik@google.com
Gerrit-Attention: Eric Lai ericllai@google.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 21 Feb 2025 20:22:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No