Ronald G. Minnich (rminnich@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3987
-gerrit
commit c1291d3497be29674e6d7c3f05cd1c39772ab9f4 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Mon Oct 21 20:23:35 2013 +0200
google/parrot/smihandler.c: Use `battery_critical_logged` only with `ELOG_GSMI`
Make the declaration and use of it conditional on the ELOG_GSMI Kconfig variable.
Change-Id: I2ef291d2f3e7d35545014e03ba8e0045da6050e5 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/mainboard/google/parrot/smihandler.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/mainboard/google/parrot/smihandler.c b/src/mainboard/google/parrot/smihandler.c index a5f6ba2..ec2c9ea 100644 --- a/src/mainboard/google/parrot/smihandler.c +++ b/src/mainboard/google/parrot/smihandler.c @@ -94,7 +94,9 @@ static u8 mainboard_smi_ec(void) { u8 src; u32 pm1_cnt; +#if CONFIG_ELOG_GSMI static int battery_critical_logged; +#endif
ec_kbc_write_cmd(0x56); src = ec_kbc_read_ob(); @@ -106,8 +108,8 @@ static u8 mainboard_smi_ec(void) if (!battery_critical_logged) elog_add_event_byte(ELOG_TYPE_EC_EVENT, EC_EVENT_BATTERY_CRITICAL); -#endif battery_critical_logged = 1; +#endif break; case EC_LID_CLOSE: printk(BIOS_DEBUG, "LID CLOSED, SHUTDOWN\n");