Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35636 )
Change subject: mb/google/variants/drallion: [WIP]Update the spd index map ......................................................................
mb/google/variants/drallion: [WIP]Update the spd index map
Change-Id: I1b2b4362b84b170bd73b760828ca300ec86c4534 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/variants/drallion/memory.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/35636/1
diff --git a/src/mainboard/google/drallion/variants/drallion/memory.c b/src/mainboard/google/drallion/variants/drallion/memory.c index 10996a3..e5144e7 100644 --- a/src/mainboard/google/drallion/variants/drallion/memory.c +++ b/src/mainboard/google/drallion/variants/drallion/memory.c @@ -23,7 +23,7 @@ static const int spd_index[32] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 4, 3, 6, 1, 0, 0, 0, 0, + 4, 5, 6, 1, 0, 0, 0, 0, 5, 0, 7, 2, 0, 0, 0, 0 };
Hello EricR Lai, Selma Bensaid, Bora Guvendik, Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35636
to look at the new patch set (#2).
Change subject: mb/google/variants/drallion: [WIP]Update the spd index map ......................................................................
mb/google/variants/drallion: [WIP]Update the spd index map
Change-Id: I1b2b4362b84b170bd73b760828ca300ec86c4534 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/variants/drallion/memory.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/35636/2
Hello EricR Lai, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35636
to look at the new patch set (#3).
Change subject: mb/google/variants/drallion: Update the spd index map ......................................................................
mb/google/variants/drallion: Update the spd index map
Change-Id: I1b2b4362b84b170bd73b760828ca300ec86c4534 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/variants/drallion/memory.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/35636/3
Hello EricR Lai, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35636
to look at the new patch set (#4).
Change subject: mb/google/variants/drallion: Update the spd index map ......................................................................
mb/google/variants/drallion: Update the spd index map
Change-Id: I1b2b4362b84b170bd73b760828ca300ec86c4534 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/variants/drallion/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/35636/4
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35636 )
Change subject: mb/google/variants/drallion: Update the spd index map ......................................................................
Patch Set 4: Code-Review+2
Hello EricR Lai, Selma Bensaid, Bora Guvendik, build bot (Jenkins), Chiranjeevi Rapolu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35636
to look at the new patch set (#6).
Change subject: mb/google/variants/drallion: Update the spd index map ......................................................................
mb/google/variants/drallion: Update the spd index map
BUG=b:141575294
Change-Id: I1b2b4362b84b170bd73b760828ca300ec86c4534 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/drallion/variants/drallion/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/35636/6
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35636 )
Change subject: mb/google/variants/drallion: Update the spd index map ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35636 )
Change subject: mb/google/variants/drallion: Update the spd index map ......................................................................
mb/google/variants/drallion: Update the spd index map
BUG=b:141575294
Change-Id: I1b2b4362b84b170bd73b760828ca300ec86c4534 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35636 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com --- M src/mainboard/google/drallion/variants/drallion/memory.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/memory.c b/src/mainboard/google/drallion/variants/drallion/memory.c index 10996a3..37d009a 100644 --- a/src/mainboard/google/drallion/variants/drallion/memory.c +++ b/src/mainboard/google/drallion/variants/drallion/memory.c @@ -23,8 +23,8 @@ static const int spd_index[32] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, - 4, 3, 6, 1, 0, 0, 0, 0, - 5, 0, 7, 2, 0, 0, 0, 0 + 0, 4, 3, 6, 1, 0, 0, 0, + 0, 5, 0, 7, 2, 0, 0, 0 };
const struct cnl_mb_cfg *get_variant_memory_cfg(struct cnl_mb_cfg *mem_cfg)
-
Aamir Bohra (Code Review) -
EricR Lai (Code Review)
-
Patrick Georgi (Code Review)