Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48128 )
Change subject: drivers/intel/fsp2_0: Remove console in weak function ......................................................................
drivers/intel/fsp2_0: Remove console in weak function
This pollutes the log on all platforms not implementing an override.
Change-Id: I0d8371447ee7820cd8e86e9d3d5e70fcf4f91e34 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/intel/fsp2_0/util.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/48128/1
diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 490816d..866db58 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -241,5 +241,4 @@
__weak void soc_validate_fsp_version(const struct fsp_header *hdr) { - printk(BIOS_DEBUG, "%s not implemented.\n", __func__); }
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48128 )
Change subject: drivers/intel/fsp2_0: Remove console in weak function ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48128 )
Change subject: drivers/intel/fsp2_0: Remove console in weak function ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48128 )
Change subject: drivers/intel/fsp2_0: Remove console in weak function ......................................................................
drivers/intel/fsp2_0: Remove console in weak function
This pollutes the log on all platforms not implementing an override.
Change-Id: I0d8371447ee7820cd8e86e9d3d5e70fcf4f91e34 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/48128 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/intel/fsp2_0/util.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 490816d..866db58 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -241,5 +241,4 @@
__weak void soc_validate_fsp_version(const struct fsp_header *hdr) { - printk(BIOS_DEBUG, "%s not implemented.\n", __func__); }
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)