Attention is currently required from: Bob Moragues, David Wu, Ren Kuo, Shelley Chen, Subrata Banik, YH Lin.
Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox: Create jubilant variant ......................................................................
Patch Set 16:
(3 comments)
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83212/comment/74ba7824_5ba841e5?usp... : PS16, Line 11: 11 12 Move this after ISH to be bits 14 15
https://review.coreboot.org/c/coreboot/+/83212/comment/e7f662ce_8b26841a?usp... : PS16, Line 15: 17 18 This should probably match the FP field in config.star (bits 11 12)
https://review.coreboot.org/c/coreboot/+/83212/comment/f2483c40_e8b9e614?usp... : PS16, Line 1: fw_config : field STORAGE 2 3 : option STORAGE_UNKNOWN 0 : option STORAGE_UFS 1 : option STORAGE_NVME 2 : end : field WIFI_BT 4 4 : option WIFI_BT_CNVI 0 : option WIFI_BT_PCIE 1 : end : field DB_USB 11 12 : option DB_1A 0 : option DB_1A_LTE 1 : end : field FPMCU 17 18 : option FPMCU_ABSENT 0 : option FPMCU_NUVOTON 1 : end : end This needs to match the config,star bits here:
http://cs/h/chrome-internal/chromeos/superproject/+/main:src/project/brox/lo...