Attention is currently required from: Bob Moragues, David Wu, Ren Kuo, Shelley Chen, Subrata Banik, YH Lin.
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
3 comments:
File src/mainboard/google/brox/variants/jubilant/overridetree.cb:
Patch Set #16, Line 11: 11 12
Move this after ISH to be bits 14 15
Patch Set #16, Line 15: 17 18
This should probably match the FP field in config.star (bits 11 12)
fw_config
field STORAGE 2 3
option STORAGE_UNKNOWN 0
option STORAGE_UFS 1
option STORAGE_NVME 2
end
field WIFI_BT 4 4
option WIFI_BT_CNVI 0
option WIFI_BT_PCIE 1
end
field DB_USB 11 12
option DB_1A 0
option DB_1A_LTE 1
end
field FPMCU 17 18
option FPMCU_ABSENT 0
option FPMCU_NUVOTON 1
end
end
This needs to match the config,star bits here:
http://cs/h/chrome-internal/chromeos/superproject/+/main:src/project/brox/lotso/config.star;l=44
To view, visit change 83212. To unsubscribe, or for help writing mail filters, visit settings.