Attention is currently required from: Felix Singer, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67820 )
Change subject: util/xcompile: Add --no-warn-rwx-segments to arm64 LD params ......................................................................
Patch Set 2:
(2 comments)
File util/xcompile/xcompile:
https://review.coreboot.org/c/coreboot/+/67820/comment/a93e368e_35a7d498 PS2, Line 312: ifneq ($(shell "${LD_${TARCH}}" --no-warn-rwx-segments --version >/dev/null 2>&1),) Why run this in make and not in xcompile already? cf. line 203 for `${LDFLAGS_ARM64_A53_ERRATUM_843419}`. In case of this change, it should be a little simpler, because there is no Kconfig to check.
This whole function (report_arch_toolchain()) is hard to parse. I guess there are more if's than necessary, e.g. when the ERRATUM variable is empty, we don't need to guard it (line 304)?
https://review.coreboot.org/c/coreboot/+/67820/comment/d2d5b100_32acfe0e PS2, Line 313: LD_${TARCH}+=" --no-warn-rwx-segments" In make, there shouldn't be quotes. Make would put them literally into the variable.