Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email )
Change subject: drivers/amd/nova: Add Nova Card directory ......................................................................
Patch Set 4:
(6 comments)
Patchset:
PS3:
not sure if i remember that correctly, but i think the result of some discussion was that moving tha […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/84776/comment/383dbd99_be9f995d?usp... : PS3, Line 7: Add common directory :
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/84776/comment/0f6c849d_a27771f2?usp... : PS3, Line 9: Creates
Create
Done
File src/mainboard/amd/common/nova/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/84776/comment/72eb1cce_23ded60b?usp... : PS3, Line 6:
I meant no blank lines at the end of files please.
Done
File src/mainboard/amd/common/nova/include/nova_card.h:
https://review.coreboot.org/c/coreboot/+/84776/comment/7084c539_3a6276eb?usp... : PS3, Line 11: uint16_t connector_type_offset;
the connector info offset inside the eeprom on the nova card is a constant that's the same for all n […]
Done
File src/mainboard/amd/common/nova/nova_card.c:
https://review.coreboot.org/c/coreboot/+/84776/comment/614836ee_68040ecf?usp... : PS3, Line 25: uint16_t connector_type = data[1] | data[0] << 8;
`code indent should use tabs where possible` […]
Done