Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81348?usp=email )
Change subject: mb/google/brox: Configure I2C timing for I2C devices ......................................................................
mb/google/brox: Configure I2C timing for I2C devices
Configure I2C0/1 timing in devicetree to meet timing requirement. (THIGH(us) minimum is 0.6us).
Before: I2C0 : THIGH(us) 0.595us I2C1 : THIGH(us) 0.582us
After: I2C0 : THIGH(us) 0.673us I2C1 : THIGH(us) 0.666us
Change-Id: I79af4fde4eb08d4eb896794756a633701bebb755 Signed-off-by: Ivy Jian ivy.jian@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81348 Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb index 3e0e7fb..9ed0602 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb +++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb @@ -97,13 +97,13 @@ .i2c[0] = { .speed = I2C_SPEED_FAST, .rise_time_ns = 650, - .fall_time_ns = 400, + .fall_time_ns = 350, .data_hold_time_ns = 50, }, .i2c[1] = { .speed = I2C_SPEED_FAST, .rise_time_ns = 600, - .fall_time_ns = 400, + .fall_time_ns = 350, .data_hold_time_ns = 50, }, .i2c[2] = {