Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74712?usp=email )
Change subject: soc/amd/picasso/chip: use common data fabric domain resource code
......................................................................
Patch Set 19:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74712/comment/ed87a79f_43a89ff6 :
PS19, Line 107: reboot
They do a lot more hibernation these days to hide their slow boot times.
yep. i have a half finished local patch that adds that info to the docs, but it'll probably take a while until i get that one cleaned up and ready for push and review. when debugging something else smoe months ago, this was why windows just didn't do anything when a bert table was generated, so i sort-of shelved that effort...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia24930ec2a9962dd15e874e9defea441cffae9f2
Gerrit-Change-Number: 74712
Gerrit-PatchSet: 19
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 06 Jun 2023 17:32:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment