Change in coreboot[master]: drivers/i2c/cs42l42: Add driver for generating device in SSDT
Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel, Zhuohao Lee, Karthik Ramasubramanian, EricR Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52395 )
Change subject: drivers/i2c/cs42l42: Add driver for generating device in SSDT ......................................................................
Patch Set 5:
(20 comments)
File src/drivers/i2c/cs42l42/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/97759caa_169a5b52 PS5, Line 6: RISE_DEB_0_MS = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/7850ea06_79111274 PS5, Line 7: RISE_DEB_125_MS = 1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/31e2e2a7_bf6c925d PS5, Line 8: RISE_DEB_250_MS = 2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/972827e9_833d00c1 PS5, Line 9: RISE_DEB_500_MS = 3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/f454f08d_cb586319 PS5, Line 10: RISE_DEB_750_MS = 4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/7f6788d4_84bf7bc9 PS5, Line 11: RISE_DEB_1000_MS = 5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/4c060f63_72b09d7a PS5, Line 12: RISE_DEB_1250_MS = 6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/3d029744_94f56be4 PS5, Line 13: RISE_DEB_1500_MS = 7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/e04c83db_9778c0a3 PS5, Line 17: FALL_DEB_0_MS = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/9d206ae3_14a966ce PS5, Line 18: FALL_DEB_125_MS = 1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/7382704a_6f00b82b PS5, Line 19: FALL_DEB_250_MS = 2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/bb048664_f2589dcf PS5, Line 20: FALL_DEB_500_MS = 3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/b69f3763_3dae95c0 PS5, Line 21: FALL_DEB_750_MS = 4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/aa3a8718_f10c5258 PS5, Line 22: FALL_DEB_1000_MS = 5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/a4a7ec9c_9d761399 PS5, Line 23: FALL_DEB_1250_MS = 6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/17799c07_5974879a PS5, Line 24: FALL_DEB_1500_MS = 7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/24fe2c97_b5f9da22 PS5, Line 28: HSBIAS_RAMP_FAST_RISE_SLOW_FALL = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/4d7cc3d1_31bf19ce PS5, Line 29: HSBIAS_RAMP_FAST = 1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/ec911737_f812d15a PS5, Line 30: HSBIAS_RAMP_SLOW = 2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117508): https://review.coreboot.org/c/coreboot/+/52395/comment/f405e475_198daf27 PS5, Line 31: HSBIAS_RAMP_SLOWEST = 3, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)