HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32425
Change subject: src/soc/intel: Remove unused variables ......................................................................
src/soc/intel: Remove unused variables
Change-Id: Ie81377a31e6527c5fd5aaea99f08527912e870a0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/fsp_broadwell_de/acpi.c 1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/32425/1
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c index a0c9ee53..b1ea093 100644 --- a/src/soc/intel/fsp_broadwell_de/acpi.c +++ b/src/soc/intel/fsp_broadwell_de/acpi.c @@ -433,7 +433,7 @@ { int ratio_min, ratio_max, ratio_step; int coord_type, power_max, power_unit, num_entries; - int ratio, power, clock, clock_max; + int ratio, power, clock; int turbo; u32 control_status; msr_t msr; @@ -448,7 +448,6 @@ msr = rdmsr(MSR_PLATFORM_INFO); ratio_min = (msr.hi >> 8) & 0xff; // LFM ratio_max = (msr.lo >> 8) & 0xff; // HFM - clock_max = (ratio_max * 100);
/* Calculate CPU TDP in mW */ msr = rdmsr(MSR_PKG_POWER_SKU_UNIT);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32425 )
Change subject: src/soc/intel: Remove unused variables ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32425 )
Change subject: src/soc/intel: Remove unused variables ......................................................................
src/soc/intel: Remove unused variables
Change-Id: Ie81377a31e6527c5fd5aaea99f08527912e870a0 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32425 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/fsp_broadwell_de/acpi.c 1 file changed, 1 insertion(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/fsp_broadwell_de/acpi.c b/src/soc/intel/fsp_broadwell_de/acpi.c index a0c9ee53..b1ea093 100644 --- a/src/soc/intel/fsp_broadwell_de/acpi.c +++ b/src/soc/intel/fsp_broadwell_de/acpi.c @@ -433,7 +433,7 @@ { int ratio_min, ratio_max, ratio_step; int coord_type, power_max, power_unit, num_entries; - int ratio, power, clock, clock_max; + int ratio, power, clock; int turbo; u32 control_status; msr_t msr; @@ -448,7 +448,6 @@ msr = rdmsr(MSR_PLATFORM_INFO); ratio_min = (msr.hi >> 8) & 0xff; // LFM ratio_max = (msr.lo >> 8) & 0xff; // HFM - clock_max = (ratio_max * 100);
/* Calculate CPU TDP in mW */ msr = rdmsr(MSR_PKG_POWER_SKU_UNIT);
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)