[XS] Change in coreboot[main]: security/vboot: Add option for enabling ADB over network via GBB flag

[Subrata Banik (Code Review)]

Attention is currently required from: Jon Murphy, Julius Werner, Kapil Porwal, Yu-Ping Wu.

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87031?usp=email )

Change subject: security/vboot: Add option for enabling ADB over network via GBB flag
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> > Thoughts?
>
> I think we should not land any designs on the main branch before they are final. That's what we have the separate bring-up branch for.
>
> I don't know what the exact situation on Fatcat is right now, but if you want to boot AL there you should still be using the bringup branch anyway(?),

ALOS FW branch clone coreboot from mainline and no local changes resides in that branch in terms of coreboot.
> and if you don't then you shouldn't need this flag. (Also, all this does is configure the default that coreboot builds the image with, you can still always manually change the image with gbb_utility afterwards.)

That is the case today, everyone requires to set GBB to enable bit 31 for ADB after downloading AL FW image. Often folks missed to do so and raise concern that ADB is not working. I'm trying to keep ADB enabled in the AP FW image so when they flash AP FW from CPFE/AL bucket they see ADB is default enabled.