Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Patrick Rudolph.
Vladimir Serbinenko has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/86247?usp=email )
Change subject: intel/acpi: Put BSP as the first entry ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86247/comment/e8cc51b8_49db7eeb?usp... : PS4, Line 9: Linux complains in dmesg as a firmware bug that BSP is not the first entry.
Could you include requirement link?
Added in the comment so it's preserved for posterity
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/86247/comment/5a603f6d_036f7fe1?usp... : PS4, Line 22: * then followed by Efficeint Cores's APIC IDs.
Could you please fix the typo on Efficient since you are editing this comment?
Done
https://review.coreboot.org/c/coreboot/+/86247/comment/c9b9111c_d8aedcad?usp... : PS4, Line 30: * This will be used
Please fill paragraph. Line length limit is 96-character.
Done